refactor(monitor): Use discrete CrossChainTransferClients#3039
Open
pxrl wants to merge 3 commits intopxrl/monitorSimplifyfrom
Open
refactor(monitor): Use discrete CrossChainTransferClients#3039pxrl wants to merge 3 commits intopxrl/monitorSimplifyfrom
pxrl wants to merge 3 commits intopxrl/monitorSimplifyfrom
Conversation
The Monitor has two use cases related to tracking crosschain transfers: protocol rebalances and relayer rebalances. Relayer rebalances are EOA -> EOA where the src and dst addresses are the same; protocol rebalances have assymetric addresses because the transfers happen from HubPool and SpokePool. This complexity is unfortunately unhandled by the Monitor and is instead pushed deep down into the bridge adapter interfaces, causing unhelpful complexity. This should instead be handled up at the Monitor level, where there's more flexibility. There are subsequent changes to follow, where the bridge adapter implementations will be unburdened of the need to infer from & to addresses on crosschain transfers based on voodoo incantations about whether the addresses are EOAs or contracts.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Monitor has two use cases related to tracking crosschain transfers:
protocol rebalances and relayer rebalances. Relayer rebalances are EOA
-> EOA where the src and dst addresses are the same; protocol rebalances
have assymetric addresses because the transfers happen from HubPool and
SpokePool. This complexity is unfortunately unhandled by the Monitor and
is instead pushed deep down into the bridge adapter interfaces, causing
unhelpful complexity. This should instead be handled up at the Monitor
level, where there's more flexibility.
There are subsequent changes to follow, where the bridge adapter
implementations will be unburdened of the need to infer from & to
addresses on crosschain transfers based on voodoo incantations about
whether the addresses are EOAs or contracts.