feat(server): Use only ox_accounts

ox_core isn't needed in this case as we only use player accounts.

Author: antond15

fxmanifest.lua

@@ -7,12 +7,9 @@ description 'Banking script with qtarget support.'
 version '2.0.0'
 
 
-shared_scripts {
-	'@ox_core/imports.lua',
-	'@ox_lib/init.lua'
-}
-
+shared_script '@ox_lib/init.lua'
 server_script 'server.lua'
+
 client_scripts {
 	'config.lua',
 	'client.lua'

server.lua

@@ -1,35 +1,33 @@
 local inventory = exports.ox_inventory
+local accounts = exports.ox_accounts
 
 lib.callback.register('orp_banking:getBalance', function(source)
-	local player = Player(source)
-	return player.getAccount('bank') or 0
+	return accounts:get(source, 'bank') or 0
 end)
 
 
 
 RegisterNetEvent('orp_banking:deposit', function(data)
-	local player = Player(source)
 	local amount = tonumber(data?.amount)
 
 	if not amount or amount <= 0 or amount > inventory:GetItem(source, 'money', false, true) then
 		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
 		inventory:RemoveItem(source, 'money', amount)
-		player.addAccount('bank', amount)
-		TriggerClientEvent('orp_banking:update', source, player.getAccount('bank'))
+		accounts:add(source, 'bank', amount)
+		TriggerClientEvent('orp_banking:update', source, accounts:get(source, 'bank'))
 		TriggerClientEvent('orp_banking:notify', source, 'You have successfully deposited $'.. amount, 'success')
 	end
 end)
 
 RegisterNetEvent('orp_banking:withdraw', function(data)
-	local player = Player(source)
-	local balance = player.getAccount('bank')
+	local balance = accounts:get(source, 'bank')
 	local amount = tonumber(data?.amount)
 
 	if not amount or amount <= 0 or amount > balance then
 		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
-		player.removeAccount('bank', amount)
+		accounts:remove(source, 'bank', amount)
 		inventory:AddItem(source, 'money', amount)
 		TriggerClientEvent('orp_banking:update', source, balance - amount)
 		TriggerClientEvent('orp_banking:notify', source, 'You have successfully withdrawn $'.. amount, 'success')
@@ -46,19 +44,17 @@ RegisterNetEvent('orp_banking:transfer', function(data)
 	elseif not amount or amount <= 0 then
 		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
-		local player = Player(source)
-		local target = Player(data.target)
-		local balance = player.getAccount('bank')
+		local balance = accounts:get(source, 'bank')
 
 		if balance <= 0 or balance < amount or amount <= 0 then
 			TriggerClientEvent('orp_banking:notify', source, 'You don\'t have enough money for this transfer', 'error')
 		else
-			player.removeAccount('bank', amount)
+			accounts:remove(source, 'bank', amount)
 			TriggerClientEvent('orp_banking:update', source, balance - amount)
 			TriggerClientEvent('orp_banking:notify', source, 'You have successfully transferred $'.. amount, 'success')
 
-			target.addAccount('bank', amount)
-			TriggerClientEvent('orp_banking:update', source, target.getAccount('bank'))
+			accounts:add(data.target, 'bank', amount)
+			TriggerClientEvent('orp_banking:update', source, accounts:get(data.target, 'bank'))
 			TriggerClientEvent('orp_banking:notify', source, 'You just received $'.. amount ..' via bank transfer', 'success')
 		end
 	end