Allow overwrite and ref targets. Adds more functionality / flexibility to action #14
Conversation
remove runs-on param
| | `tag` | A Git tag name. | `string` | `true` | `N/A` | | ||
| | `message` | A message for the Git tag. | `string` | `false` | `''` | | ||
| | `ref` | Commit SHA or tag to target. | `string` | `false` | `''` | | ||
| | `force` | A message for the Git tag. | `boolean`| `false` | `false` | |
There was a problem hiding this comment.
Please fix desciption of the force paramater
| | `message` | A message for the Git tag. | `string` | `false` | `''` | | ||
| | `ref` | Commit SHA or tag to target. | `string` | `false` | `''` | | ||
| | `force` | A message for the Git tag. | `boolean`| `false` | `false` | | ||
| | `always-pass`| If step should pass if tag push fails | `boolean`| `false` | `false` | |
There was a problem hiding this comment.
always-pass sounds weird. ignore-failures maybe? Or always-succeed?
| id: get-latest-tag | ||
|
|
||
| - uses: actions-ecosystem/action-bump-semver@v1 | ||
| - uses: thejeff77/action-bump-semver@v1.0.0 |
There was a problem hiding this comment.
+1 about use of actions-ecosystem
If you do a PR to original repo it should stay as is. In your own repo feel free to override it.
| level: minor | ||
|
|
||
| - uses: actions-ecosystem/action-push-tag@v1 | ||
| - uses: thejeff77/action-push-tag@v1.0.0 |
There was a problem hiding this comment.
Same here. +1 about use of actions-ecosystem
| name: Push Any Git Tag | ||
| description: based on Actions Ecosystem Push Tag - Fixed with additional features. | ||
| author: Actions Ecosystem & theJeff77 |
There was a problem hiding this comment.
I wouldn't change these. Nor do you need to put your name in as the author just because you PR.
| using: "composite" | ||
| steps: |
There was a problem hiding this comment.
I feel like this is an unnecessary over reach on this PR. Just leave it in the Dockerfile and make your changes in the entrypoint.sh.
mikesigs
left a comment
mikesigs
left a comment
There was a problem hiding this comment.
I am not the owner of this repo, but I am interested in your PR so I gave it a review.
|
@micnncim This would be a nice addition. |
vlavrynovych
left a comment
vlavrynovych
left a comment
There was a problem hiding this comment.
- Don't replace owner's info like action name, desc, author
- Fix description of the
forceparameter - Add examples for the new parameters
| id: get-latest-tag | ||
|
|
||
| - uses: actions-ecosystem/action-bump-semver@v1 | ||
| - uses: thejeff77/action-bump-semver@v1.0.0 |
There was a problem hiding this comment.
+1 about use of actions-ecosystem
If you do a PR to original repo it should stay as is. In your own repo feel free to override it.
| level: minor | ||
|
|
||
| - uses: actions-ecosystem/action-push-tag@v1 | ||
| - uses: thejeff77/action-push-tag@v1.0.0 |
There was a problem hiding this comment.
Same here. +1 about use of actions-ecosystem
| | `tag` | A Git tag name. | `string` | `true` | `N/A` | | ||
| | `message` | A message for the Git tag. | `string` | `false` | `''` | | ||
| | `ref` | Commit SHA or tag to target. | `string` | `false` | `''` | | ||
| | `force` | A message for the Git tag. | `boolean`| `false` | `false` | |
There was a problem hiding this comment.
Please fix desciption of the force paramater
| | ------------ | -------------------------------------- | -------- | -------- | ------- | | ||
| | `tag` | A Git tag name. | `string` | `true` | `N/A` | | ||
| | `message` | A message for the Git tag. | `string` | `false` | `''` | | ||
| | `ref` | Commit SHA or tag to target. | `string` | `false` | `''` | |
There was a problem hiding this comment.
It will be nice to update example in the README.MD with an real case where you use all the new parameters.
For example: it's not clear if the force parameter is analog of git force or it's something else. And why would I need a ref
| name: Push Any Git Tag | ||
| description: based on Actions Ecosystem Push Tag - Fixed with additional features. | ||
| author: Actions Ecosystem & theJeff77 |
| type: string | ||
| required: false | ||
| force: | ||
| description: Whether or not to force push (overwrite) the tag if it already exists. Useful for walking tags. |
There was a problem hiding this comment.
This descriptions are not available for me when I read the docs or trying to see it will work for me
3 participants
What this PR does / Why we need it
Adds two new optional variables:
Which issue(s) this PR fixes
Fixes #
#13
#12