Fix: add rustup default check #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for the attempt. I published a different solution for #74 in v1.15.2. I think this is the wrong way to solve it by messing with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain installation via the rust-toolchain/rust-toolchain.toml file, using the rust_src_dir flag, does not automatically set a global default in CI/CD.
This PR adds a check that sets the default value in case it has not been correctly set after the toolchain installation.
Env details:
App + rust submodule (rust-toolchain.toml)
GitHub Actions runner
runs-on: ubuntu-24.04
container-image: quay.io/pypa/manylinux_2_28_x86_64
Fixes #74