This repository was archived by the owner on Dec 12, 2020. It is now read-only.
Add stack-root output #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avh4
force-pushed
the
stack-root-output
branch
from
308d267 to
b28505f
Compare
hazelweakly
reviewed
Sep 17, 2020
| exec('stack', ['setup', opts.ghc.resolved]) | ||
| ); | ||
| await core.group('Pre-installing GHC with stack', async () => { | ||
| await exec('stack', ['setup', opts.ghc.resolved]); |
There was a problem hiding this comment.
This codepath isn't executed every time stack is installed. The action first checks to see if the tool already exists, and if so, exits early. The success function in src/installer.ts is responsible for setting this up correctly and is probably the best place to put this logic.
I'm glad this was submitted, though! Walking through the code helped me realize that I had placed some stack specific code beyond the early exit codepath, making it (probably) possible to end up with a windows system without STACK_ROOT set correctly.
Merged
mihaimaruseac
added a commit
to mihaimaruseac/hindent
that referenced
this pull request
Nov 23, 2020
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack-root is where snapshot dependencies are stored, and this path is commonly needed when enabling caching. Adding it as an output to setup-haskell allows the client projects to not have to worry about the platform-specific logic to determine which path should be cached.