Skip to content

Update Regex to Support All ASDF Versions for the supported distributions in tool-versions File #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarithaVattikuti merged 20 commits into from
Sep 16, 2025
Merged

Update Regex to Support All ASDF Versions for the supported distributions in tool-versions File #767

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4dcdbcd
Regex update to fix #719
aparnajyothi-y Mar 18, 2025
7872dcf
Check failures fix
aparnajyothi-y Mar 20, 2025
0bd6823
npm run format, npm run format-check & npm run build
aparnajyothi-y Mar 20, 2025
cb386ac
Regex update
aparnajyothi-y Mar 21, 2025
368c98a
regex update
aparnajyothi-y Apr 28, 2025
b0d0904
Merge remote-tracking branch 'origin/main' into toolversions-regex-up…
aparnajyothi-y Apr 28, 2025
cfefdbc
Merge branch 'main' into toolversions-regex-update
aparnajyothi-y Apr 28, 2025
a35ec49
fixed check failures
aparnajyothi-y Apr 28, 2025
88a3812
updated regex
aparnajyothi-y May 5, 2025
cda1881
regex update for all the versions
aparnajyothi-y May 16, 2025
4482507
regex and docmentation update
aparnajyothi-y May 30, 2025
c981c0e
Regex update
aparnajyothi-y Jul 2, 2025
250752c
format and doc update
aparnajyothi-y Jul 28, 2025
8fa56ab
doc format update
aparnajyothi-y Jul 30, 2025
2ccd746
npm audit fix
aparnajyothi-y Jul 31, 2025
f4d4543
resolve conflicts
aparnajyothi-y Aug 4, 2025
684674e
resolve conflicts
aparnajyothi-y Aug 4, 2025
baaaebd
resolve conflicts
aparnajyothi-y Aug 4, 2025
f7a12f1
doc update
aparnajyothi-y Aug 11, 2025
7b9321c
Java version upgrade
aparnajyothi-y Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/cleanup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93634,7 +93634,7 @@ function getVersionFromFileContent(content, distributionName, versionFile) {
const versionFileName = getFileName(versionFile);
if (versionFileName == '.tool-versions') {
javaVersionRegExp =
/^(java\s+)(?:\S*-)?v?(?<version>(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m;
/^java\s+(?:\S*-)?(?<version>\d+(?:\.\d+)*([+_.-](?:openj9[-._]?\d[\w.-]*|java\d+|jre[-_\w]*|OpenJDK\d+[\w_.-]*|[a-z0-9]+))*)/im;
}
else {
javaVersionRegExp = /(?<version>(?<=(^|\s|-))(\d+\S*))(\s|$)/;
Expand Down
2 changes: 1 addition & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131639,7 +131639,7 @@ function getVersionFromFileContent(content, distributionName, versionFile) {
const versionFileName = getFileName(versionFile);
if (versionFileName == '.tool-versions') {
javaVersionRegExp =
/^(java\s+)(?:\S*-)?v?(?<version>(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m;
/^java\s+(?:\S*-)?(?<version>\d+(?:\.\d+)*([+_.-](?:openj9[-._]?\d[\w.-]*|java\d+|jre[-_\w]*|OpenJDK\d+[\w_.-]*|[a-z0-9]+))*)/im;
}
else {
javaVersionRegExp = /(?<version>(?<=(^|\s|-))(\d+\S*))(\s|$)/;
Expand Down
8 changes: 8 additions & 0 deletions docs/advanced-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,5 +614,13 @@ major versions: 8, 11, 16, 17, 21
more specific versions: 8.0.282+8, 8.0.232, 11.0, 11.0.4, 17.0
early access (EA) versions: 15-ea, 15.0.0-ea
versions with specified distribution: openjdk64-11.0.2
LTS versions : temurin-21.0.5+11.0.LTS
```
If the file contains multiple versions, only the first one will be recognized.
***NOTE:
In some complex version strings containing multiple version-like segments (e.g., java semeru-openj9-11.0.15+10_openj9-0.32.0),
the regular expression may extract the last version segment (0.32.0) instead of the intended main version (11.0.15+10).
Additionally, Recommended to use supported standard semantic versioning (semver) formats
and may not correctly parse non-standard formats such as jetbrains-21b212.1.
Users are encouraged to provide clear, semver-compliant version specifications to ensure accurate extraction.

2 changes: 1 addition & 1 deletion src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export function getVersionFromFileContent(
const versionFileName = getFileName(versionFile);
if (versionFileName == '.tool-versions') {
javaVersionRegExp =
/^(java\s+)(?:\S*-)?v?(?<version>(\d+)(\.\d+)?(\.\d+)?(\+\d+)?(-ea(\.\d+)?)?)$/m;
/^java\s+(?:\S*-)?(?<version>\d+(?:\.\d+)*([+_.-](?:openj9[-._]?\d[\w.-]*|java\d+|jre[-_\w]*|OpenJDK\d+[\w_.-]*|[a-z0-9]+))*)/im;
Comment on lines 135 to +136
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern is extremely complex and hard to read/maintain. Consider breaking it down into smaller, named components or using multiple regex patterns with clear comments explaining each part's purpose.

Copilot uses AI. Check for mistakes.
} else {
javaVersionRegExp = /(?<version>(?<=(^|\s|-))(\d+\S*))(\s|$)/;
}
Expand Down
Loading