-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Note non-exact versions syntax installing outdated versions #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Closes actions#1236 Closes actions#1114 Closes actions#940 As extensively documented in actions#1236 and actions#940, the non-exact aliases `lts/*`, `*`, `current`, `latest`, and `22` are slow to be upgraded, lagging several days behind the Node.js releases. Let users know about this downside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the README documentation to warn users about potential delays when using non-exact Node.js version aliases in GitHub Actions workflows.
- Adds a warning that non-exact version aliases (
lts/*
,*
,latest
, etc.) can be several days outdated - Recommends using specific versions for timely upgrades
README.md
Outdated
@@ -123,7 +123,7 @@ Examples: | |||
- NVM LTS syntax: `lts/erbium`, `lts/fermium`, `lts/*`, `lts/-n` | |||
- Latest release: `*` or `latest`/`current`/`node` | |||
|
|||
**Note:** Like the other values, `*` will get the latest [locally-cached Node.js version](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#nodejs), or the latest version from [actions/node-versions](https://github.com/actions/node-versions/blob/main/versions-manifest.json), depending on the [`check-latest`](docs/advanced-usage.md#check-latest-version) input. | |||
**Note:** If you require timely version upgrades, use specific versions like `22.18.0` and upgrade the versions yourself. Values like `lts/*`, `*`, `latest`, etc. will get the latest [locally-cached Node.js version](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#nodejs), or the latest version from [actions/node-versions](https://github.com/actions/node-versions/blob/main/versions-manifest.json), depending on the [`check-latest`](docs/advanced-usage.md#check-latest-version) input. Both can be several days outdated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The sentence structure is overly complex and could be difficult to follow. Consider breaking this into separate sentences or restructuring for better readability.
**Note:** If you require timely version upgrades, use specific versions like `22.18.0` and upgrade the versions yourself. Values like `lts/*`, `*`, `latest`, etc. will get the latest [locally-cached Node.js version](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#nodejs), or the latest version from [actions/node-versions](https://github.com/actions/node-versions/blob/main/versions-manifest.json), depending on the [`check-latest`](docs/advanced-usage.md#check-latest-version) input. Both can be several days outdated. | |
**Note:** If you require timely version upgrades, use specific versions like `22.18.0` and upgrade the versions yourself. | |
Values like `lts/*`, `*`, `latest`, etc. will get the latest [locally-cached Node.js version](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#nodejs), or the latest version from [actions/node-versions](https://github.com/actions/node-versions/blob/main/versions-manifest.json). | |
Which version you get depends on the [`check-latest`](docs/advanced-usage.md#check-latest-version) input. | |
Both can be several days outdated. |
Copilot uses AI. Check for mistakes.
Closes #1236
Closes #1114
Closes #940
Description:
As extensively documented in #1236 and #940, the non-exact aliases
lts/*
,*
,current
,latest
, and22
are slow to be upgraded, lagging several days behind the Node.js releases.Let users know about this downside.
Related issue:
lts/*
installs old LTS versions up to 1 month+ after release #1236lts/*
installs old LTS version intermittently #940Check list: