Skip to content

Fix maximum call stack size error #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix maximum call stack size error #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca95a8e
Fix maximum call stack size error
Serious-senpai Apr 16, 2025
acc84f1
Merge branch 'actions:main' into patch-1
Serious-senpai Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/glob/__tests__/internal-globber.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,22 @@ describe('globber', () => {
}
})

it('captures large number of files', async () => {
const root = path.join(getTestTemp(), 'large-number-of-files')
await fs.mkdir(root, {recursive: true})

const promises: Promise<void>[] = []
for (let i = 0; i < 150000; i++) {
promises.push(
fs.writeFile(path.join(root, `item-${i}.txt`), 'test file content')
)
}

await Promise.all(promises)
const itemPaths = await glob(`${root}${path.sep}*`)
expect(itemPaths.length).toEqual(150000)
})

it('defaults to followSymbolicLinks=true', async () => {
// Create the following layout:
// <root>
Expand Down
11 changes: 7 additions & 4 deletions packages/glob/src/internal-globber.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,13 @@ export class DefaultGlobber implements Globber {

// Push the child items in reverse
const childLevel = item.level + 1
const childItems = (await fs.promises.readdir(item.path)).map(
x => new SearchState(path.join(item.path, x), childLevel)
)
stack.push(...childItems.reverse())
const childItems = await fs.promises.readdir(item.path)

for (let i = childItems.length - 1; i >= 0; i--) {
stack.push(
new SearchState(path.join(item.path, childItems[i]), childLevel)
)
}
}
// File
else if (match & MatchKind.File) {
Expand Down