improve glob performance by not ignoring negate #2107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657
In a pnpm monorepo, I have the following patterns to upload with
upload-artifact
:However, because a deep
apps/app-a/node_modules/abc
is a partial match, the globber goes through files in a directory that will be filtered out later anyway.This reduces the time to find all matches from 1m 8s to 250ms with identical result arrays.