Automatically eager load all integrations when in Rails context #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production mode it's preferable to load all the code upfront even if it means loading some code that won't be used. This is because loading the code on demand cause the first request to use it to be slower, and to flush various VM caches such as the global constant cache. It also degrade Copy on Write performance for forking setups.
casperisfine
force-pushed
the
eager-loading
branch
from
74e43c9 to
a31d366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production mode it's preferable to load all the code upfront even if it means loading some code that won't be used.
This is because loading the code on demand cause the first request to use it to be slower, and to flush various VM caches such as the global constant cache. It also degrade Copy on Write performance for forking setups.