This repository was archived by the owner on Mar 30, 2022. It is now read-only.
Validator for "in" where clause and integration with Rails 4#112
Open
ka8725 wants to merge 3 commits intoactiverecord-hackery:masterfrom
Open
Validator for "in" where clause and integration with Rails 4#112ka8725 wants to merge 3 commits intoactiverecord-hackery:masterfrom
ka8725 wants to merge 3 commits intoactiverecord-hackery:masterfrom
Conversation
When I'm trying to run tests in terminal with `rake` command I see the following errors: * rake should be included to Gemfile * sqlite3 should be included in the Gemfile This changes fix these issues
When I pass in where array like ["", ""] it must not generate select like select * from somthing where id in (NULL)
|
merge this patch please :)) |
Author
|
It seems that @ernie has no longer supported this gem - the last change was 1 year ago |
Author
|
Added integration with rails 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of checkboxes for form helper generates array of params like this (I don't select any checkbox and use "id_in" predicate):
Validator pass them and gem generates wrong select like this:
So my changes fix this issue