This repository was archived by the owner on Mar 30, 2022. It is now read-only.
fix for #checks with string values#75
Open
eostrom wants to merge 4 commits intoactiverecord-hackery:masterfrom
Open
fix for #checks with string values#75eostrom wants to merge 4 commits intoactiverecord-hackery:masterfrom
eostrom wants to merge 4 commits intoactiverecord-hackery:masterfrom
Conversation
but label_tag does, so the input's ID was invalid and also different from the label's FOR attribute.
Useful if you need to represent more information about each choice than just the label and the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when I tried to create checkboxes with string values, some of the labels weren't clickable. It's because for values that had spaces in them, the IDs generated for the checkbox inputs also had spaces in them. I fixed it by copying some code from a private method in FormTagHelper.