permanent redirect status code instead of found#3757
Closed
francesco-gaglione wants to merge 3 commits intoactix:masterfrom
Closed
permanent redirect status code instead of found#3757francesco-gaglione wants to merge 3 commits intoactix:masterfrom
francesco-gaglione wants to merge 3 commits intoactix:masterfrom
Conversation
Member
|
I agree Found is less appropriate but permanent redirects are a risky default for a framework due to their caching implications. I'd accept a change to TemporaryRedirect or allow a customization. |
Contributor
Author
|
@robjtede if customization is prefered I can try to work on it. I wa thinking to change |
Member
a new method would be preferred to avoid breaking changes, but in spirit i agree it's a good path to take |
Contributor
Author
|
@robjtede working on it. This merge request will be obsolete and will be included in the new one. |
Contributor
Author
|
Opened #3767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Close #3543
PR Checklist
Documentation comments have been added / updated.Overview