Conversation
confirmed new tests fail as expected
robjtede
changed the title
JohnTitor
reviewed
Mar 10, 2026
| /// ``` | ||
| pub fn iter(&self) -> Iter<'_> { | ||
| Iter::new(self.inner.iter()) | ||
| Iter::new(self.inner.iter(), self.len()) |
Member
There was a problem hiding this comment.
pre-existing but len() does a bit more work than usual:
actix-web/actix-http/src/header/map.rs
Line 169 in c86f230
I'm not sure how its full scan affects performance, but I guess we could inline the length inside map 🤔
Member
Author
There was a problem hiding this comment.
ye i was thinking about that too, good optimisation target for another PR
JohnTitor
approved these changes
Mar 10, 2026
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
LGTM with or without addressing my comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
PR Checklist
Overview
Fixes #3969