Skip to content

feat: simplify GridSurfaceMaterial classes#4408

Closed
asalzburger wants to merge 5 commits intoacts-project:mainfrom
asalzburger:feat-simplify-grid-material
Closed

feat: simplify GridSurfaceMaterial classes#4408
asalzburger wants to merge 5 commits intoacts-project:mainfrom
asalzburger:feat-simplify-grid-material

Conversation

@asalzburger
Copy link
Contributor

This PR simplifies the GridSurfaceMaterial family:

  • remove scale() method for all ISurfaceMaterial objects, it is not used and can be easily done in manipulation of the disk storage classes (particularly after feat: move ROOT surface material map I/O to plugins #4400 is done)
  • Merge IndexedSurfaceMaterial and GloballyIndexedSurfaceMaterial into one class
  • Restrict toLocal and grid types to actual surface types

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

@asalzburger asalzburger marked this pull request as draft July 9, 2025 08:43
@asalzburger asalzburger added this to the next milestone Jul 9, 2025
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

📊: Physics performance monitoring for d7d72fa

Full contents

physmon summary

@sonarqubecloud
Copy link

@github-actions github-actions bot added the Stale label Aug 13, 2025
@asalzburger asalzburger deleted the feat-simplify-grid-material branch March 18, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant