refactor: Minor cleanup of GainMatrixUpdater
#4825
Merged
+11
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
paulgessinger
left a comment
paulgessinger
left a comment
There was a problem hiding this comment.
I think both chi2 calculations are equivalent, if I'm reading Frühwirth right.
Why do we want to change this?
Core/include/Acts/TrackFitting/detail/GainMatrixUpdaterImpl.hpp
Outdated
Show resolved
Hide resolved
Contributor
Author
This was more of a suspicion after a discussion a few weeks ago. For me/us it was not obvious that they are equivalent. Stephen mentioned that one might be numerically favorable over the other. We will check that later this week. In any case the refactor seems still beneficial to me |
andiwand
changed the title
GainMatrixUpdaterGainMatrixUpdater
Contributor
Author
|
I will wait for #4890 to go in to see if this / what is still relevant |
Collaborator
acts-project-service
added
the
Breaks Athena build
andiwand
removed
🛑 blocked
andiwand
changed the title
GainMatrixUpdaterGainMatrixUpdater
paulgessinger
approved these changes
Jan 21, 2026
|
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constwhere possible--- END COMMIT MESSAGE ---
blocked by