Skip to content

fix: limit external-eic-shell error reports to downstream use only #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wdconinc wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: limit external-eic-shell error reports to downstream use only #4907

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
877d126
fix: limit external-eic-shell error reports to downstream use only
wdconinc Dec 12, 2025
2125060
Ensure CMAKE_INSTALL_PREFIX is set
wdconinc Dec 12, 2025
5f9511e
Change CMAKE_INSTALL_PREFIX to /work/prefix to ensure persistence
wdconinc Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,10 @@ jobs:
restore-keys: |
ccache-${{ runner.os }}-${{ github.job }}-${{ env.CCACHE_KEY_SUFFIX }}-

- name: Build
id: build
- name: Build ACTS
id: build-acts
uses: addnab/docker-run-action@v3
continue-on-error: true
continue-on-error: false
with:
image: "ghcr.io/eic/eic_ci_without_acts:nightly"
options: -v ${{ github.workspace }}:/work -v ${{ env.CCACHE_DIR }}:/root/.cache/ccache
Expand All @@ -416,7 +416,7 @@ jobs:
pushd acts
ccache -p | grep cache_dir
ccache -z && \
export CMAKE_INSTALL_PREFIX=$HOME/prefix
export CMAKE_INSTALL_PREFIX=/work/prefix
export CMAKE_CXX_COMPILER_LAUNCHER=ccache
echo "::group::Acts configure phase"
cmake -B build -S . \
Expand All @@ -433,6 +433,24 @@ jobs:
echo "::endgroup::"
popd

- name: Build EICrecon
id: build-eicrecon
uses: addnab/docker-run-action@v3
continue-on-error: true
with:
image: "ghcr.io/eic/eic_ci_without_acts:nightly"
options: -v ${{ github.workspace }}:/work -v ${{ env.CCACHE_DIR }}:/root/.cache/ccache
shell: bash
run: |
for script in /.singularity.d/env/*.sh; do
if [ -f "$script" ]; then
. "$script"
fi
done
cd /work
set -ue
export CMAKE_INSTALL_PREFIX=/work/prefix
export CMAKE_CXX_COMPILER_LAUNCHER=ccache
pushd EICrecon
echo "::group::EICrecon configure phase"
ccache -z && \
Expand All @@ -447,17 +465,17 @@ jobs:

ccache -s

- name: Create comment body
if: ${{ steps.build.outcome == 'failure' && github.event_name == 'pull_request' }}
- name: Create comment body header
if: ${{ steps.build-eicrecon.outcome == 'failure' && github.event_name == 'pull_request' }}
run: |
cat >comment-50-external-failure.md <<EOF
# ❗️: Downstream build failure

- eic-shell (cc @acts-project/epic-contacts)
- eic-shell EICrecon (cc @acts-project/epic-contacts)
EOF

- name: Upload Artifact
if: ${{ steps.build.outcome == 'failure' && github.event_name == 'pull_request' }}
if: ${{ steps.build-eicrecon.outcome == 'failure' && github.event_name == 'pull_request' }}
uses: actions/upload-artifact@v5
with:
name: comment-50-external-failure.md
Expand Down
Loading