-
Notifications
You must be signed in to change notification settings - Fork 231
refactor: Muon Mockup Detector Builder: refactoring and adding endcaps #4922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
junggjo9
reviewed
Dec 26, 2025
...tectors/GeoModelDetector/include/ActsExamples/GeoModelDetector/GeoModelMuonMockupBuilder.hpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
dimitra97
reviewed
Jan 6, 2026
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
dimitra97
reviewed
Jan 6, 2026
...tectors/GeoModelDetector/include/ActsExamples/GeoModelDetector/GeoModelMuonMockupBuilder.hpp
Outdated
Show resolved
Hide resolved
junggjo9
reviewed
Jan 6, 2026
...tectors/GeoModelDetector/include/ActsExamples/GeoModelDetector/GeoModelMuonMockupBuilder.hpp
Outdated
Show resolved
Hide resolved
dimitra97
reviewed
Jan 6, 2026
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp
Outdated
Show resolved
Hide resolved
…s to a separate method
junggjo9
approved these changes
Jan 12, 2026
|
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



I refactored
GeoModelMuonMockupBuilderso that converted boxes are processed per station to produce a station-levelStaticBluePrintNode. Then these nodes are attached to the appropriate container.Due to the stacking policy, three containers are attached to the root
Blueprintand stacked along Z: one for the detector body and two for the big wheels. While theStaticBluePrintNodes for EM and EO are directly attached to the big-wheels containers, the body container is further composed of two containers stacked along R: the barrel container, which holds the BI, BM, BO station nodes stacked along R, and a second cylindrical container that contains the small wheels, stacked along Z.--- END COMMIT MESSAGE ---
@junggjo9 @dimitra97