chore: remove broken Mat_map_surface_plot_*.C macros #4929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes four obsolete ROOT macros for material mapping surface plotting that no longer function due to the removal of sur_type and sur_range_min/max fields in PR #4353. Additionally, it cleans up unused variable declarations in the remaining detector plot macro.
- Deletion of broken macros that relied on removed tree branches
- Cleanup of unused
sur_typevariable declaration in Mat_map_detector_plot.C
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Mat_map_surface_plot_ratio.C | Deleted - macro depended on removed surface type and range fields |
| Mat_map_surface_plot_dist.C | Deleted - macro depended on removed surface type and range fields |
| Mat_map_surface_plot_1D.C | Deleted - macro depended on removed surface type and range fields |
| Mat_map_surface_plot.C | Deleted - macro depended on removed surface type and range fields |
| Mat_map_detector_plot.C | Removed unused sur_type variable declaration and branch address binding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Contributor
|
I am not familiar with these scripts and there purpose - do you think you could have a look @asalzburger ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sur_type and sur_range_min/max were removed in #4353, so these macros don't work anymore, as they require this information recorded. It looks like there is a move towards Python macros such as material_mapping_check.py, so these can be removed.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.