-
Notifications
You must be signed in to change notification settings - Fork 228
chore!: remove ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector
#4938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 5 commits into
acts-project:main
from
asalzburger:chore-remove-ISurfaceProvider
Jan 7, 2026
Merged
chore!: remove ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector
#4938
kodiakhq
merged 5 commits into
acts-project:main
from
asalzburger:chore-remove-ISurfaceProvider
Jan 7, 2026
+1
−1,517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector
32fde3a to
82adc66
Compare
paulgessinger
approved these changes
Jan 7, 2026
Contributor
|
should this be considered as breaking? |
Contributor
Author
There was no client for this, except some early testing, but we should be consistent, so yes. |
ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetectorISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector
|
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



This removes the ISurface provider and the Kdt based Gen1 TrackingGeometry builder.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.