Skip to content

chore!: remove ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Jan 7, 2026
Merged

chore!: remove ISurfaceProvider and (Gen1) KDTTrackingGeometry builder & ProtoDetector #4938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6775237
remove ProtoDetector and KdtTrackingGeometry builder
asalzburger Jan 7, 2026
be4de93
remove Gen1 type KdtSurfaces based geometry building
asalzburger Jan 7, 2026
82adc66
adding docs
asalzburger Jan 7, 2026
7d4a804
Merge branch 'main' into chore-remove-ISurfaceProvider
asalzburger Jan 7, 2026
cbdbc43
Merge branch 'main' into chore-remove-ISurfaceProvider
kodiakhq[bot] Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions Core/include/Acts/Geometry/ISurfacesProvider.hpp
View file
Open in desktop

This file was deleted.

123 changes: 0 additions & 123 deletions Core/include/Acts/Geometry/KDTreeTrackingGeometryBuilder.hpp
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions ...ude/Acts/Geometry/KdtSurfacesProvider.hpp → Core/include/Acts/Geometry/KdtSurfaces.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#pragma once

#include "Acts/Definitions/Algebra.hpp"
#include "Acts/Geometry/ISurfacesProvider.hpp"
#include "Acts/Geometry/ReferenceGenerators.hpp"
#include "Acts/Surfaces/Surface.hpp"
#include "Acts/Utilities/AxisDefinitions.hpp"
Expand Down Expand Up @@ -154,41 +153,4 @@ class KdtSurfaces {
}
};

/// @brief Callable struct wrapper around the KDT surface structure
///
/// This allows to create small region based callable structs at
/// configuration level that are then connected to an InternalStructureBuilder
template <std::size_t kDIM = 2u, std::size_t bSize = 100u>
class KdtSurfacesProvider : public ISurfacesProvider {
public:
/// The prefilled surfaces in a KD tree structure, it is generally shared
/// amongst different providers
///
/// @param kdts the prefilled KDTree structure
/// @param kregion the region where these are pulled from
KdtSurfacesProvider(std::shared_ptr<KdtSurfaces<kDIM, bSize>> kdts,
const Extent& kregion)
: m_kdt(std::move(kdts)), m_region(kregion) {
/// Sanity check that the KDTree is not empty
if (m_kdt == nullptr) {
throw std::invalid_argument(
"KdtSurfacesProvider: no KDTree structure provided.");
}
}

/// The call to provide the surfaces
/// @param gctx Geometry context (not used in KDT provider)
/// @return Vector of surfaces from the KDT query
std::vector<std::shared_ptr<Surface>> surfaces(
[[maybe_unused]] const GeometryContext& gctx) const final {
return m_kdt->surfaces(m_region);
}

private:
std::shared_ptr<KdtSurfaces<kDIM, bSize, reference_generator>> m_kdt =
nullptr;
/// The query region
Extent m_region;
};

} // namespace Acts
147 changes: 0 additions & 147 deletions Core/include/Acts/Geometry/ProtoDetector.hpp
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions Core/src/Geometry/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ target_sources(
CylinderVolumeBuilder.cpp
CylinderVolumeHelper.cpp
Extent.cpp
KDTreeTrackingGeometryBuilder.cpp
DiscLayer.cpp
GenericApproachDescriptor.cpp
GenericCuboidVolumeBounds.cpp
Expand Down Expand Up @@ -44,7 +43,6 @@ target_sources(
CompositePortalLink.cpp
PortalLinkBase.cpp
PortalError.cpp
ProtoDetector.cpp
CylinderPortalShell.cpp
CuboidPortalShell.cpp
BlueprintNode.cpp
Expand Down
Loading
Loading