refactor!: Distinct MultiComponentTrackParameters#5150
Merged
kodiakhq[bot] merged 33 commits intoacts-project:mainfrom Mar 17, 2026
Merged
refactor!: Distinct MultiComponentTrackParameters#5150kodiakhq[bot] merged 33 commits intoacts-project:mainfrom
MultiComponentTrackParameters#5150kodiakhq[bot] merged 33 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
…ackparams-toSingle
…feat-multitrackparams-toSingle
…acts into cleanup-multitrackparams
Contributor
Member
benjaminhuth
left a comment
benjaminhuth
left a comment
There was a problem hiding this comment.
Looks good, just a few comments at the moment
Member
benjaminhuth
left a comment
benjaminhuth
left a comment
There was a problem hiding this comment.
Thanks, very nice. I have some minor comments still
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouples the
MultiComponentTrackParametersinterface from the usual bound track parameters. This is motivated by their distinct nature. AMultiComponentTrackParameterscannot be uniquely represented as a single bound track parameter but requires a user specified merging procedure.Additionally, refactors the component storage to use SoA over AoS to model optional covariance more efficiently.
--- END COMMIT MESSAGE ---
blocked by
MultiComponentBoundTrackParameters::merge#5137