Skip to content

chore: Surface & Volume remove deprecated symbols#5176

Merged
paulgessinger merged 2 commits intoacts-project:mainfrom
junggjo9:RemoveDepGeo
Mar 17, 2026
Merged

chore: Surface & Volume remove deprecated symbols#5176
paulgessinger merged 2 commits intoacts-project:mainfrom
junggjo9:RemoveDepGeo

Conversation

@junggjo9
Copy link
Copy Markdown
Contributor

@junggjo9 junggjo9 commented Feb 28, 2026

  • Remove transform() from the Surface
  • Delete the DetectorElementBase
  • Remove all global position methods without geoCtx from volume
  • Remove center variable from volume

--- END COMMIT MESSAGE ---

@github-actions github-actions bot added this to the next milestone Feb 28, 2026
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Feb 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2026

📊: Physics performance monitoring for 7a7bb25

Full contents

physmon summary

❗️: Downstream build failure

  • eic-shell (cc @acts-project/epic-contacts)

@paulgessinger
Copy link
Copy Markdown
Member

Let's sync this with a major version. Either v46 or v47. What do you think @andiwand ?

@andiwand
Copy link
Copy Markdown
Contributor

andiwand commented Mar 2, 2026

yes lets sync this with a major version

@paulgessinger paulgessinger merged commit 314fde5 into acts-project:main Mar 17, 2026
35 of 47 checks passed
@sonarqubecloud
Copy link
Copy Markdown

veprbl added a commit to eic/EICrecon that referenced this pull request Mar 17, 2026
github-merge-queue bot pushed a commit to eic/EICrecon that referenced this pull request Mar 17, 2026
@andiwand andiwand modified the milestones: next, v46.0.0 Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Component - Examples Affects the Examples module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants