Skip to content

feat: Gen3 DD4hep construction#5193

Draft
paulgessinger wants to merge 55 commits intoacts-project:mainfrom
paulgessinger:feat/dd4hep-gen3
Draft

feat: Gen3 DD4hep construction#5193
paulgessinger wants to merge 55 commits intoacts-project:mainfrom
paulgessinger:feat/dd4hep-gen3

Conversation

@paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Mar 3, 2026

No description provided.

@github-actions github-actions bot added this to the next milestone Mar 3, 2026
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Mar 3, 2026
@tmadlener tmadlener mentioned this pull request Mar 6, 2026
Open
2 tasks
@tmadlener
Copy link
Contributor

tmadlener commented Mar 6, 2026

From my point of view, I am pretty happy with the state of this. I have exercised a few of the geometries we have in k4geo in key4hep/k4ActsTracking#36 and at least for me the still existing amount of boilerplate is acceptable (and probably also necessary) given the layouts of the tracking devices we have.

tmadlener
tmadlener reviewed Mar 9, 2026
View reviewed changes
Core/include/Acts/Geometry/BlueprintBuilder.hpp
Comment on lines +213 to +215
/// @tparam BackendT Geometry backend satisfying @ref detail::BlueprintBackend.
template <detail::BlueprintBackend BackendT>
class ElementLayerAssembler {
Copy link
Contributor

@tmadlener tmadlener Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would a layer assembler for planar layers / testbeam like setups go in this new scheme? In the original API we simply introduced a PlaneLayerHelper similar to the original LayerHelper for that. Should that go into a dedicated Assembler or is this one general enough to also accomodate a LayerType::Planar, you think?

Tagging @RainWindWang as well here, since she did the original implementation.

Copy link
Member Author

@paulgessinger paulgessinger Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think that it should scale to plane layers, it only needs to produce the corresponding container type. But I agree that this is something we should explicitly foresee!

@paulgessinger paulgessinger mentioned this pull request Mar 17, 2026
Open
paulgessinger and others added 20 commits March 20, 2026 14:10
@paulgessinger
feat: Add check for SurfaceArray grid + transform handling improvement
6571c62
@paulgessinger
comment checkGrid, make private
ee41a25
@paulgessinger
MERGE
7f00311
@paulgessinger
feat: First draft for partial DD4hep Gen3 support
11f5998
@paulgessinger
feat: Test Gen3 DD4hep code on ODD
90416f7
@paulgessinger
fix: Add missing symbol
03343c6
@paulgessinger
fix: dd4hep -> DD4hep on disk
818a201
@paulgessinger
layer helper API and use it
ba6c9ac
@paulgessinger
(sort of) auto detect layer transform if axes are specified
69b9feb
@paulgessinger
feat: Beampipe maker for blueprint builder
f53134d
@paulgessinger
rename addLayer -> makeLayer
64b5cb0
@paulgessinger
add flag to LayerHelper whether empty is ok or not
048c6c3
@paulgessinger
remove artifact
2613b72
@paulgessinger
fix beampipe builder and make it build to r=0
515d948
@paulgessinger
fix: Check if cylinder conversion failed
83ab4f8
@tmadlener @paulgessinger
Make the layer names use the full path name
b455f79
@tmadlener @paulgessinger
Use boost join
f13116b
@paulgessinger
api exploration
ef47a85
@paulgessinger
customizer MUST return shared pointer
811f00c 
it also gets the layer node as a shared pointer now
@tmadlener @paulgessinger
Fix missing include
dd09ef1 
Necessary for gcc13 (Ubuntu24)
paulgessinger and others added 29 commits March 20, 2026 17:31
@paulgessinger
api drafting
802aec9
@paulgessinger
lots of api drafting
e8732af
@paulgessinger
split into impl file
c079ec0
@paulgessinger
reduce backend concept and api surface
044c5c4
@paulgessinger
make some useful methods public
ee70eff
@paulgessinger
add nodiscard to builder interface methods
f38c463
@paulgessinger
api refactor splitting up the multi-duty assemblers into separate ones
dc4d84d
@paulgessinger
cc docs update
a0e80db
@paulgessinger
improve ODD for illustrative purposes
3395dce
@paulgessinger
centralize constant lookup
e048642
@paulgessinger
clean up: add plane layer helper
26acb4e 
tmadlener: Lifted from previous work on the old API proposal design
@paulgessinger
layerType check
0db00c6 
tmadlener: Lifted from earlier work done on the old API design proposal
@tmadlener @paulgessinger
Make customizers more generic
456d378 
Do not prescribe CylinderContainers
@tmadlener @paulgessinger
Add first facilities for handling Plane Layers
a96610f 
Some helpers and at least some of the necessary disambiguation
@tmadlener @paulgessinger
Remove old code from original API design
37b7f08
@tmadlener @paulgessinger
Remove some unnecessary / leftover changes
bfb742a
@paulgessinger
blueprintbuilder impl tuning
1731677
@paulgessinger
move odd construction to free funcs in core
2746d86
@paulgessinger
docs update
681947d
@paulgessinger
lint
005ea36
@paulgessinger
feat(DD4hep/Root): add initial TGeo blueprint backend and ODD harness
9ca9025
@paulgessinger
refactor(Root): make the TGeo blueprint backend lazy and path-derived
e080e21
@paulgessinger
refactor(DD4hep/TGeo): move beampipe handling to DD4hep and simplify …
a6bbadb 
…TGeo
@paulgessinger
refactor(Blueprint): make barrel-endcap classification optional for b…
d480fdf 
…ackends
@paulgessinger
fix(DD4hep): use stable grouped layer names and align Gen3 geometry c…
5b62434 
…ounts
@paulgessinger
fix(TGeo ODD): expose volume metadata in Python and match Gen3 counts
3ffdb7e
@paulgessinger
dd4hep: make TGeo layer customization self-contained
99eebfa 
Move ODD TGeo constants/layer binning logic into the DD4hep builder path and remove the generic TGeoBackend constant-provider plumbing.
@paulgessinger
prepare for tgeo backend
51c52e6
@paulgessinger
include tuning, namespaces
65e8d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tmadlener tmadlener tmadlener left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

2 participants

@paulgessinger @tmadlener