refactor: Improved FPE mon, extend to macOS#5231
Merged
kodiakhq[bot] merged 25 commits intoacts-project:mainfrom Mar 17, 2026
Merged
refactor: Improved FPE mon, extend to macOS#5231kodiakhq[bot] merged 25 commits intoacts-project:mainfrom
kodiakhq[bot] merged 25 commits intoacts-project:mainfrom
Conversation
…et bug, add fault location tracking
…rate source files
- Remove verbose try_compile block, use find_package(Backtrace) - Consolidate backtrace setup logic
- Use consistent COMPILE_DEFINITIONS syntax (no leading -D)
- Add FpeMonitorPlatformDarwinCommon.hpp with shared exceptMaskForType, fpeTypeFromSiCode - Deduplicate between Darwin arm64 and x86_64
- Move from DarwinCommon to FpeMonitorPlatform.hpp for shared use - Darwin arm64 uses platform header, DarwinCommon keeps darwin-specific helpers
Enable ACTS_BUILD_PLUGIN_FPEMON in shared and CI-specific presets. Remove ACTS_SEQUENCER_DISABLE_FPEMON runtime opt-outs from GitHub and GitLab jobs. Drop redundant macOS-only configure override now covered by presets.
github-actions
bot
added
the
Infrastructure
Contributor
paulgessinger
force-pushed
the
refactor/fpemon
branch
from
1f3ab7e to
d7fb26e
Compare
paulgessinger
force-pushed
the
refactor/fpemon
branch
from
750ab6f to
ff7cfbc
Compare
andiwand
previously approved these changes
Mar 14, 2026
Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp
Outdated
Show resolved
Hide resolved
stephenswat
approved these changes
Mar 16, 2026
Member
stephenswat
left a comment
stephenswat
left a comment
There was a problem hiding this comment.
I am no expert on ARM but this looks sensible to me. 👍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the FPE (Floating Point Exception) monitoring plugin, focusing on cross-platform support, improved exception handling, and enhanced stack trace recording. The main themes are platform abstraction, improved signal handling, and more robust stack trace deduplication.
Platform abstraction and cross-platform support:
CMakeLists.txtto support Darwin (macOS) and Linux architectures, enabling FPE monitoring on more systems. (Plugins/FpeMonitoring/CMakeLists.txt)FpeMonitorPlatform.hppand refactored code to use platform abstraction functions for exception handling, signal masking, and stack trace capture. (Plugins/FpeMonitoring/src/FpeMonitorPlatform.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]Improved signal handling and exception processing:
Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]isSupported()method toFpeMonitorto check runtime support for trapping-based FPE monitoring. (Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]Enhanced stack trace recording and deduplication:
Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2] [3] [4]Plugins/FpeMonitoring/src/FpeMonitor.cpp)Build system and configuration improvements:
CMAKE_DL_LIBSfor linking, improved detection and setup for stacktrace support, and added platform-specific source selection. (Plugins/FpeMonitoring/CMakeLists.txt) [1] [2] [3]Minor fixes and improvements:
pushOffsetand added missing header includes for portability. (Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp) [1] [2]Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]Platform abstraction and cross-platform support
Plugins/FpeMonitoring/CMakeLists.txt)FpeMonitorPlatform.hppand refactored code to use platform abstraction for exception handling, signal masking, and stack trace capture. (Plugins/FpeMonitoring/src/FpeMonitorPlatform.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]Improved signal handling and exception processing
Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]isSupported()method toFpeMonitorto check runtime support for trapping-based FPE monitoring. (Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]Enhanced stack trace recording and deduplication
Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp,Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2] [3] [4]Plugins/FpeMonitoring/src/FpeMonitor.cpp)Build system and configuration improvements
CMAKE_DL_LIBSfor linking, improved detection and setup for stacktrace support, and added platform-specific source selection. (Plugins/FpeMonitoring/CMakeLists.txt) [1] [2] [3]Minor fixes and improvements
pushOffsetand added missing header includes for portability. (Plugins/FpeMonitoring/include/ActsPlugins/FpeMonitoring/FpeMonitor.hpp) [1] [2]Plugins/FpeMonitoring/src/FpeMonitor.cpp) [1] [2]