feat: Add check for SurfaceArray grid + transform handling improvement#5247
Open
paulgessinger wants to merge 2 commits intoacts-project:mainfrom
Open
feat: Add check for SurfaceArray grid + transform handling improvement#5247paulgessinger wants to merge 2 commits intoacts-project:mainfrom
paulgessinger wants to merge 2 commits intoacts-project:mainfrom
Conversation
paulgessinger
force-pushed
the
push-qrmtpvpyvuyk
branch
from
4ef46a9 to
a92d8dd
Compare
Contributor
paulgessinger
force-pushed
the
push-qrmtpvpyvuyk
branch
from
a92d8dd to
6571c62
Compare
|
andiwand
approved these changes
Mar 23, 2026
| ACTS_VERBOSE("- z-position of disc estimated as " << Z); | ||
| ACTS_VERBOSE("- full transform is \n" << fullTransform.matrix()); | ||
|
|
||
| if (fullTransform.translation().norm() < s_transformEquivalentTolerance) { |
Contributor
There was a problem hiding this comment.
I wonder if it would make sense to steer this explicitly here with something like
const bool handleTransform = transform.isApprox(Transform3::Identity());
// ...
if (handleTransform) {
fullTransform.translate(Vector3::UnitZ() * Z);
}at some point we should revisit the interface. at least for me, every time I look at it I wonder what the transform really does in what case and what the contract is here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by:
to#5246