chore!: Deprecate templated seeding#5261
Merged
kodiakhq[bot] merged 13 commits intoacts-project:mainfrom Mar 21, 2026
Merged
Conversation
github-actions
bot
added
Component - Core
andiwand
force-pushed
the
deprecate-templated-seeding
branch
from
1675b30 to
e9838a0
Compare
Contributor
paulgessinger
previously approved these changes
Mar 20, 2026
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
paulgessinger
approved these changes
Mar 20, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After we fully migrated to the new non-templated seeding and space point algorithms and EDM it is time to deprecate the templated ones. Apart from this tests are already removed. A future breaking change will remove the code completely and rename the new implementation to remove the
2, for examplesSpacePointContainer2->SpacePointContainer.Quick update guide:
SeedFinder->TripletSeederCylindricalSpacePointGrid->CylindricalSpacePointGrid2Seed->SeedContainer2,SeedProxy2SpacePointContainer2,SpacePointProxy2SpacePointBuilder->PixelSpacePointBuilderStripSpacePointBuilder->StripSpacePointBuilderMoving our Examples from the old EDM to the new one was done here #5088
--- END COMMIT MESSAGE ---