Skip to content

Conversation

@stephenswat
Copy link
Member

This commit enables our fitting algorithms to use prefitted tracks, such that we can reuse the fitting information from the CKF. Note that we also preserve the ability to work with unfitted tracks.

This commit implements polymorphic storage types, so we can remove the
detector-specific types from the algorithms and reduce boilerplate.
@stephenswat stephenswat added the feature New feature or request label Aug 28, 2025
@stephenswat
Copy link
Member Author

Depends on #1068.

This commit enables our fitting algorithms to use prefitted tracks, such
that we can reuse the fitting information from the CKF. Note that we
also preserve the ability to work with unfitted tracks.
@stephenswat stephenswat force-pushed the feat/remove_first_forward_fit branch from 1a7489d to 9a8e8df Compare August 28, 2025 14:02
@sonarqubecloud
Copy link

@stephenswat
Copy link
Member Author

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298342 to 298340 (-0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 101335 to 101334 (-0.0%)

Finding plots









Track fitting performance

Total number of fitted tracks went from 101335 to 101334 (-0.0%)

Fitting plots












Note

This is an automated message produced on the explicit request of a human being.

@beomki-yeo
Copy link
Contributor

Probably we can do better review after #1068 is merged as the current change is pretty massive.
Meanwhile, could you explain how this PR saves the list of sensitive and passive surfaces passed during the CKF, which should be used in the backward fitting?

@stephenswat
Copy link
Member Author

Meanwhile, could you explain how this PR saves the list of sensitive and passive surfaces passed during the CKF, which should be used in the backward fitting?

I'm still working on this, but I'll have a prototype soon!

@stephenswat
Copy link
Member Author

Closing in favour of #1149.

@stephenswat stephenswat closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants