-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Update to detray v0.104.1 #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c47560f to
24f6a43
Compare
24f6a43 to
819e4d3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
819e4d3 to
be0ca8a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
17c242c to
ae61849
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ae61849 to
b2382a5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
0b210f4 to
b19126e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
b09e140 to
56ed477
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cea18b8 to
3e32fda
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
0c20f47 to
cf93431
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c2c619a to
27f98f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
27f98f9 to
b97c82c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f18ab01 to
8234613
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
8234613 to
31e756d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
31e756d to
4bc8979
Compare
|
The slowdown is expected from the more complex intersection handling in the new detray version (would be my assumption) |
4bc8979 to
ddc2084
Compare
|
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298342 to 298342 (+0.0%) Track finding performanceTotal number of found tracks went from 55979 to 55970 (-0.0%) Track fitting performanceNote This is an automated message produced on the explicit request of a human being. |


































In the new detray version, the mask tolerances are scaled according to the positional and directional covariances found on the previous surfaces (scaled with the distance to the next surface, but not transported with a full Jacobian). This will allow to open (and close) the surface finding tolerances dynamically, according to how well known the track model is. Since this can lead to including more surfaces in the CKF on which ultimately no fitting measurement could be found (and hence would lead to the loss of the track due to an increased hole count), the navigator now knows if a surface was only included due to an "edge hit" in the tolerance band. In this case, no hole is flagged and the track can be kept alive. Any data like this, which needs to be retained after the propagation is halted, has been added to the new
propagation_datastruct that is passed between the different kernels. The last and second last sensitive visited is added to the CKF-aborter, so that no propagation loops on now overlapping surfaces occur.Edit: The mask tolerance scaling is turned off for the CKF but enabled for the KF (by the defaults in the propagation config).