Skip to content

Conversation

@niermann999
Copy link
Contributor

@niermann999 niermann999 commented Oct 16, 2025

In the new detray version, the mask tolerances are scaled according to the positional and directional covariances found on the previous surfaces (scaled with the distance to the next surface, but not transported with a full Jacobian). This will allow to open (and close) the surface finding tolerances dynamically, according to how well known the track model is. Since this can lead to including more surfaces in the CKF on which ultimately no fitting measurement could be found (and hence would lead to the loss of the track due to an increased hole count), the navigator now knows if a surface was only included due to an "edge hit" in the tolerance band. In this case, no hole is flagged and the track can be kept alive. Any data like this, which needs to be retained after the propagation is halted, has been added to the new propagation_data struct that is passed between the different kernels. The last and second last sensitive visited is added to the CKF-aborter, so that no propagation loops on now overlapping surfaces occur.

Edit: The mask tolerance scaling is turned off for the CKF but enabled for the KF (by the defaults in the propagation config).

@niermann999 niermann999 force-pushed the detray-update branch 4 times, most recently from c47560f to 24f6a43 Compare October 17, 2025 16:21
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from 17c242c to ae61849 Compare October 28, 2025 13:38
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 changed the title feat: Update to detray v0.104.0 feat: Update to detray v0.104.1 Oct 28, 2025
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from 0b210f4 to b19126e Compare October 28, 2025 16:42
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from b09e140 to 56ed477 Compare October 29, 2025 14:53
@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from cea18b8 to 3e32fda Compare November 2, 2025 16:44
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from 0c20f47 to cf93431 Compare November 4, 2025 18:07
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 4 times, most recently from c2c619a to 27f98f9 Compare November 5, 2025 10:10
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the detray-update branch 3 times, most recently from f18ab01 to 8234613 Compare November 5, 2025 15:20
@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@stephenswat

This comment was marked as outdated.

@niermann999
Copy link
Contributor Author

niermann999 commented Nov 6, 2025

The slowdown is expected from the more complex intersection handling in the new detray version (would be my assumption)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@stephenswat
Copy link
Member

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298342 to 298342 (+0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 55979 to 55970 (-0.0%)

Finding plots









Track fitting performance

Fitting plots



















Note

This is an automated message produced on the explicit request of a human being.

@niermann999 niermann999 merged commit 41b5dd9 into acts-project:main Nov 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants