Update track covariance estimation logic

[stephenswat]

This commit reworks the covariance estimation logic to match that used in ACTS. It greatly increases the covariances of tracks, hopefully increasing the tracking efficiency.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.4% Duplication on New Code

See analysis details on SonarQube Cloud

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298342 (-0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 63306 to 63628 (+0.5%)

Finding plots

Track fitting performance

Total number of fitted tracks went from 63306 to 63628 (+0.5%)

Fitting plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	7a19579	8552bc0	Delta	7a19579	8552bc0
propagate_to_next_surface	9.83 ms	9.42 ms	-4.2%	2.89	2.97
fit_forward	3.05 ms	3.70 ms	21.1%	5.21	4.85
fit_backward	1.63 ms	1.68 ms	3.0%	3.83	3.65
find_tracks	1.25 ms	1.30 ms	4.2%	1.77	1.75
ccl_kernel	830.92 μs	831.00 μs	0.0%	1.37	1.37
Thrust::sort	728.84 μs	728.62 μs	-0.0%	3.85	3.84
count_doublets	629.78 μs	629.95 μs	0.0%	1.61	1.61
count_triplets	589.48 μs	590.72 μs	0.2%	1.02	1.02
find_doublets	453.65 μs	442.08 μs	-2.5%	3.08	3.08
find_triplets	172.18 μs	172.94 μs	0.4%	1.32	1.31
select_seeds	53.10 μs	52.99 μs	-0.2%	1.34	1.34
remove_duplicates	38.98 μs	36.98 μs	-5.1%	16.60	17.31
populate_grid	23.33 μs	23.40 μs	0.3%	1.22	1.22
count_grid_capacities	22.09 μs	22.13 μs	0.2%	1.22	1.22
fit_prelude	16.55 μs	17.26 μs	4.3%	15.24	14.54
apply_interaction	17.01 μs	16.70 μs	-1.8%	5.80	5.86
update_triplet_weights	15.03 μs	15.10 μs	0.4%	1.27	1.27
estimate_track_params	14.34 μs	14.42 μs	0.6%	2.15	2.15
form_spacepoints	13.14 μs	13.17 μs	0.2%	1.48	1.48
fill_finding_propagation_sort_keys	11.02 μs	10.77 μs	-2.3%	6.32	6.42
build_tracks	6.51 μs	6.78 μs	4.1%	10.25	9.81
reduce_triplet_counts	6.28 μs	6.30 μs	0.4%	3.08	3.08
fill_finding_duplicate_removal_sort_keys	3.33 μs	3.19 μs	-4.3%	22.39	23.18
unknown	2.06 μs	2.07 μs	0.3%	9.85	9.85
fill_fitting_sort_keys	225.64 ns	238.66 ns	5.8%	15.37	14.68
fill_prefix_sum	171.94 ns	171.89 ns	-0.0%	341.30	341.30
Total	19.41 ms	19.74 ms	1.7%	3.17	3.19

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Warning

At least one kernel incurred a significant performance regression.

Note

This is an automated message produced upon the explicit request of a human being.