Skip to content

Conversation

@stephenswat
Copy link
Member

This commit updates the Kálmán fitter error handling code by explicitly marking failures in the forward and backwards fitting step. It also resolves an issue where the smoother would start from invalid track states.

@stephenswat stephenswat added the bug Something isn't working label Nov 3, 2025
@stephenswat

This comment was marked as outdated.

This commit updates the Kálmán fitter error handling code by explicitly
marking failures in the forward and backwards fitting step. It also
resolves an issue where the smoother would start from invalid track
states.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@stephenswat
Copy link
Member Author

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298338 (-0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 55967 to 55963 (-0.0%)

Finding plots









Track fitting performance

Fitting plots





















Note

This is an automated message produced on the explicit request of a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants