Skip to content

Conversation

@niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 5, 2025

Fix several small bugs:

  • wrap the phi and theta angles the same way as ACTS does
  • Move the error checks in the gain matrix update and two filter smoother to where the data is that they are checking
  • Reject faulty input track parameters in the CKF, instead of at the end of the KF
  • Allow more mask tolerance in the direct navigator. This saves a few tracks, but does not solve the underlying bug that the direct navigator oscillates around the surface until the kalman aborter stops it.
  • rename the THETA_ZERO error to THETA_POLE for clarity
  • add new error states for invalid covariance matrices after smoothing or filtering (which otherwise can trigger and assertion in detray)
  • add the momentum aborter to the forward and backward fit

@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the fix-KF branch 6 times, most recently from 34e522d to 1ced46d Compare November 6, 2025 15:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@stephenswat
Copy link
Member

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298342 to 298342 (+0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 55979 to 55970 (-0.0%)

Finding plots









Track fitting performance

Fitting plots



















Note

This is an automated message produced on the explicit request of a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants