Skip to content

fix: Several small bugs in the KF #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix: Several small bugs in the KF #1180

merged 1 commit into from
Nov 7, 2025

Conversation

@niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 5, 2025 •
edited
Loading

Fix several small bugs:

  • wrap the phi and theta angles the same way as ACTS does
  • Move the error checks in the gain matrix updater and two filter smoother to where the data is produced that they are checking
  • Reject faulty input track parameters in the CKF, instead of at the end of the KF
  • Allow more mask tolerance in the direct navigator. This saves a few tracks, but does not solve the underlying bug that the direct navigator oscillates around the surface until the kalman aborter stops it.
  • rename the THETA_ZERO error to THETA_POLE for clarity

@stephenswat

This comment was marked as outdated.

Sign in to view
@niermann999 niermann999 force-pushed the fix-KF branch 8 times, most recently from 9058316 to 358b694 Compare November 6, 2025 16:15
@stephenswat

This comment was marked as outdated.

Sign in to view
@stephenswat
Copy link
Member

stephenswat commented Nov 7, 2025

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298343 (-0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 55960 to 55971 (+0.0%)

Finding plots









Track fitting performance

Fitting plots



















Note

This is an automated message produced on the explicit request of a human being.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@niermann999 niermann999 added the bug Something isn't working label Nov 7, 2025
@niermann999 niermann999 merged commit a5449ab into acts-project:main Nov 7, 2025
29 checks passed
@stephenswat
Copy link
Member

stephenswat commented Nov 7, 2025

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

KernelReciprocal ThroughputParallelism
41b5dd99b9e116Delta41b5dd99b9e116
propagate_to_next_surface8.49 ms8.45 ms-0.5%3.383.37
fit_forward2.58 ms2.53 ms-2.1%6.136.12
fit_backward1.38 ms1.22 ms-12.0%4.584.57
find_tracks1.19 ms1.21 ms1.9%1.851.84
ccl_kernel829.69 μs831.70 μs0.2%1.371.37
Thrust::sort708.70 μs708.38 μs-0.0%3.763.76
count_doublets630.99 μs621.95 μs-1.4%1.611.61
count_triplets590.86 μs589.25 μs-0.3%1.021.02
find_doublets449.09 μs443.09 μs-1.3%3.083.08
find_triplets172.26 μs173.02 μs0.4%1.311.31
select_seeds53.15 μs53.21 μs0.1%1.341.34
remove_duplicates27.21 μs27.19 μs-0.1%22.4822.46
populate_grid23.39 μs23.34 μs-0.2%1.221.22
count_grid_capacities22.13 μs22.08 μs-0.2%1.221.22
apply_interaction15.15 μs15.14 μs-0.1%6.516.51
update_triplet_weights15.10 μs15.08 μs-0.2%1.271.27
estimate_track_params14.35 μs14.32 μs-0.3%2.152.15
fit_prelude13.75 μs13.73 μs-0.2%18.2718.26
form_spacepoints13.14 μs13.11 μs-0.3%1.481.48
fill_finding_propagation_sort_keys9.30 μs9.30 μs-0.0%7.327.33
reduce_triplet_counts6.30 μs6.29 μs-0.1%3.083.08
build_tracks4.95 μs5.00 μs1.0%12.2712.26
unknown2.06 μs2.06 μs-0.2%9.859.85
fill_finding_duplicate_removal_sort_keys1.86 μs1.85 μs-0.3%32.5932.67
fill_fitting_sort_keys186.08 ns186.90 ns0.4%18.3718.37
fill_prefix_sum171.94 ns171.99 ns0.0%341.30341.30
Total17.25 ms16.99 ms-1.5%3.573.54

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niermann999 @stephenswat