-
Notifications
You must be signed in to change notification settings - Fork 58
Update to alpaka 2.0 #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to alpaka 2.0 #1212
Conversation
|
Hit by #1211 |
|
Passes tests on AMD locally, CPU in CI. |
|
|
Ready for review (@krasznaa @stephenswat) I think #1211 is likely just to do with our complicated HIP configuration and can be solved independently. |
krasznaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the CI is happy, I'm happy for this to go in, Let's just put back the TRACCC_ALPAKA_PATCH variable as an empty string. 😉
|
krasznaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Update to alpaka 2.0 * Specify HIP standard * Remove obsolete patches * Reinstate patch variable for future use if needed --------- Co-authored-by: Stewart Martin-Haugh <smh@cern.ch>



Remove dependency on boost. Remains to be seen if we still need to patch printf. Otherwise appears to build cleanly without changes required. I'd like to see the CI run before any more large-scale tests.