Fix account breakdown percentage calculation in net totals mode#10
Closed
MatissJanis wants to merge 2 commits intomainfrom
Closed
Fix account breakdown percentage calculation in net totals mode#10MatissJanis wants to merge 2 commits intomainfrom
MatissJanis wants to merge 2 commits intomainfrom
Conversation
…nhance unit tests - Corrected the denominator used for account breakdown percentages in net totals mode to reflect the sum of absolute values of net spending, ensuring accurate percentage calculations. - Added unit tests for account breakdown percentage calculations in both net totals and absolute modes, including scenarios with negative net spending and edge cases.
✅ Deploy Preview for actual-wrapped ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Updated the account breakdown pie chart to use absolute values for rendering, ensuring compatibility with Recharts, which does not handle negative values well. - Preserved original net spending values for display in tooltips and statistics, enhancing the clarity of financial data representation. - Filtered out accounts with zero net spending from the chart to improve visual accuracy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.