Skip to content

Conversation

@actuarysailor
Copy link
Owner

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

This PR updates all Docker-based hooks in .pre-commit-hooks.yaml to include default: false. This prevents these hooks from running by default on environments like pre-commit.ci, which do not support Docker, and avoids related errors. The hooks can still be enabled locally or in CI environments where Docker is available.

How can we test changes

  • Run pre-commit locally and verify Docker-based hooks still work when enabled.
  • Confirm that pre-commit.ci no longer attempts to run Docker-based hooks and does not error.
  • CI workflows (e.g., GitHub Actions) should continue to run Docker-based hooks

Copilot AI review requested due to automatic review settings August 16, 2025 00:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents Docker-based pre-commit hooks from running by default on environments that don't support Docker (like pre-commit.ci) by adding default: false to all Docker-based hooks in the configuration file.

  • Adds default: false to seven Docker-based hooks to prevent automatic execution
  • Maintains backward compatibility by allowing manual enablement in environments with Docker support
  • Resolves errors on pre-commit.ci service which cannot execute Docker-based hooks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@actuarysailor actuarysailor merged commit dd977d1 into main Aug 16, 2025
61 checks passed
@actuarysailor actuarysailor deleted the fix/do-not-run-docker-hooks-on-precommit.ci branch August 16, 2025 00:06
github-actions bot pushed a commit that referenced this pull request Aug 16, 2025
## [1.101.1](v1.101.0...v1.101.1) (2025-08-16)

### Bug Fixes

* Disable docker hooks on pre-commit.ci ([#5](#5)) ([dd977d1](dd977d1))
@github-actions
Copy link

This PR is included in version 1.101.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants