Feature/optimize layout using articulation points#719
Open
johannesdeselaers wants to merge 25 commits intodevelopfrom
Open
Feature/optimize layout using articulation points#719johannesdeselaers wants to merge 25 commits intodevelopfrom
johannesdeselaers wants to merge 25 commits intodevelopfrom
Conversation
…f mergeable but invalid size
… ignoring of insignificant Articulation Points
…timizeLayoutUsingArticulationPoints
…feature/optimizeLayoutUsingArticulationPoints
Contributor
|
Relayouting speed (after releasing the brush) is fine for me.
|
Contributor
Author
|
hmm, about the laggy interaction: no idea As for the increased number of plates: that is expected. |
Contributor
|
Any updates on the slower interaction? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should be merged after #691
checks of second checkmark of #431 , thus closes #431
please tell me if you think the relayout runtime is acceptable, or whether this still needs optimization
I did not take the (debug) coloring of the articulation points out for the moment, so you can see what's going on (blue = insignificant articulation point, green = significant articulation point that should be fixed). This should be done before merging this pull request.