Conversation
tgoslee
left a comment
tgoslee
left a comment
There was a problem hiding this comment.
Great job! I left some comments on your PR for things you did well and things you can refactor. Look at the comments and let me know if you have any questions.
| def create_movie(title, genre, rating): | ||
| pass | ||
| def create_movie(movie_title, genre, rating): | ||
| new_movie = {} |
There was a problem hiding this comment.
Instead of creating an empty dictionary, you can build a dictionary literal an example could look like
if title and genre and rating:
movie = {
"title": title,
"genre": genre,
"rating": rating
}
return movie| pass | ||
| def create_movie(movie_title, genre, rating): | ||
| new_movie = {} | ||
| if movie_title == None or genre == None or rating == None: |
There was a problem hiding this comment.
Here you are supposed to check if this is truthy but this only checks for None. To check if it's truthy you could so something like if not title or not genre or not rating
| user_data['watchlist'].append(movie) | ||
| return user_data | ||
|
|
||
| def watch_movie(user_data, title): |
There was a problem hiding this comment.
To avoid iterating and modifying data at the same time, in this case, you could create one for loop with an if conditional that removes the movie from the watchlist and adds the movie to watched in one loop. As soon as we make a change we want to stop iterating. Here is a suggestion:
def watch_movie(user_data, title):
for movie in user_data["watchlist"]:
if movie["title"] == title:
user_data["watchlist"].remove(movie)
user_data["watched"].append(movie)
break
return user_data| count = 0 | ||
| for movie in user_data["watchlist"]: | ||
| if movie["title"] == title: | ||
| add_to_watched(user_data,movie) |
| def get_watched_avg_rating(user_data): | ||
| sum = 0 | ||
| for i in range (0,len(user_data["watched"])): | ||
| print(user_data["watched"][i]["rating"]) |
There was a problem hiding this comment.
remove print statements after debugging/testing. Print statements should only be added if it related to the user experience
| genre_count = genre_counts.get(genre,0) | ||
| genre_counts[genre] = genre_count + 1 | ||
| counter +=1 | ||
| max_genre = max(genre_counts, key=genre_counts.get) |
There was a problem hiding this comment.
Great use of the max method here. If you didn't use the max method what would you do in its place?
| for i in range(len(user_data['watched'])): | ||
| watched_list.append(user_data["watched"][i]) | ||
| for i in range(len(user_data['friends'])): | ||
| for movie in range(len(user_data['friends'][i]["watched"])): | ||
| friends_watched.append(user_data['friends'][i]["watched"][movie]) | ||
| for movie in friends_watched: | ||
| if movie not in watched_list: | ||
| list_difference.append(movie) |
There was a problem hiding this comment.
these lines of code are similar to lines 67-77. This would be a good candidate for a helper function.
| # ------------- WAVE 4 -------------------- | ||
| # ----------------------------------------- | ||
|
|
||
| def get_available_recs(user_data): |
| # ----------------------------------------- | ||
| # ------------- WAVE 5 -------------------- | ||
| # ----------------------------------------- | ||
| def get_new_rec_by_genre(user_data): |
| movie_recommendations.append(movie) | ||
| return movie_recommendations | ||
|
|
||
| def get_rec_from_favorites(user_data): |
There was a problem hiding this comment.
instead of doing two for loops you could do something like
def get_rec_from_favorites(user_data):
movies = get_unique_watched(user_data)
recs = []
for movie in movies:
if movie in user_data['favorites']:
recs.append(movie)
return recs2 participants
Sea Turtles
Katina Carranza