Skip to content

fix(cmake): include CPM.make before calling CPMAddPackage #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 1 commit into from
Jan 23, 2026
+9 −9
Merged

fix(cmake): include CPM.make before calling CPMAddPackage #1064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ option(ADA_USE_SIMDUTF "Whether to use SIMDUTF for IDNA" OFF)
# projects as submodules or subdirectories (via FetchContent) can lead to
# errors due to CPM, so this is here to support disabling all the testing
# and tooling for ada if one only wishes to use the ada library.
if(ADA_TESTING OR ADA_BENCHMARKS OR ADA_TOOLS)
if(ADA_TESTING OR ADA_BENCHMARKS OR ADA_TOOLS OR ADA_USE_SIMDUTF)
include(cmake/CPM.cmake)
# CPM requires git as an implicit dependency
# We use googletest in the tests
Expand Down Expand Up @@ -90,15 +90,15 @@ if(ADA_TESTING OR ADA_BENCHMARKS OR ADA_TOOLS)
if (ADA_TESTING AND EMSCRIPTEN)
add_subdirectory(tests/wasm)
endif(ADA_TESTING AND EMSCRIPTEN)
endif()

if(ADA_USE_SIMDUTF)
CPMAddPackage(
NAME simdutf
GITHUB_REPOSITORY simdutf/simdutf
VERSION 7.3.2
OPTIONS "SIMDUTF_TESTS OFF" "SIMDUTF_TOOLS OFF"
)
if(ADA_USE_SIMDUTF)
CPMAddPackage(
NAME simdutf
GITHUB_REPOSITORY simdutf/simdutf
VERSION 7.3.2
OPTIONS "SIMDUTF_TESTS OFF" "SIMDUTF_TOOLS OFF"
)
endif()
endif()

add_library(ada::ada ALIAS ada)
Expand Down
Loading