Fix active3 pinouts swapped pins R and B #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants were actually backwards from the way they were named.
Active3was intended to be RGB, andActive3BGRintended to be BGR.I confirmed the pin orders on the schematic for the triple matrix bonnet here: https://learn.adafruit.com/adafruit-triple-led-matrix-bonnet-for-raspberry-pi-with-hub75/downloads
And by running the single panel simpletest on one of the same panels that I ran the triple matrix test on. With the change from this PR both now draw the colors expected on the same panels using the same RGB pinout configurations.
I changed the triple matrix simpletest example to use the default pinout instead of the BGR one. This got set to BGR before due to the pins being internally swapped.