Missing standby time constant values as per datasheet#48
Missing standby time constant values as per datasheet#48FoamyGuy merged 4 commits intoadafruit:mainfrom
Conversation
Missing standby timeconstant values as per datasheet
Missing standby time constant values as per datasheet
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Thanks for adding these, I noticed some other seemingly incorrect constants have those values already.
adafruit_bmp280.py
Outdated
There was a problem hiding this comment.
values 0x06 and 0x07 seem to already have named constants here.
But looking in the datasheet it does appear that 10 and 20 ms as the names here state is incorrect, those values aren't listed in the this table of the datasheet:
Can you please also remove STANDBY_TC_10 and STANDBY_TC_20 so that we will not end up with duplicated constant values with differing names.
Good point! OK, I removed the invalid standby time constant values. |
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Didn't test hardware, but confirmed new values match datasheet.
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7343 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_AS7343#1 from adafruit/examples Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.3.10 from 3.3.9: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#48 from stroobandt/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.2.0 from 1.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_TM#20 from adafruit/tmp119
2 participants
Two longer standby time constant values (2000 and 4000 ms) were missing as specified in the BMP280 datasheet.
I have an application for the longest one.