Support for Websocket CONT frames/fragmented messages #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐ Added:
🪛Fixes:
Websocket.receive()no longer returns payload on PING messages Fixes Ping requests pollute websocket receive streams #110TimeoutErroradded as alternative froOSError(ETIMEDOUT)for CPython 3.10->= FixesTimeoutErrorin CPython example starting from 3.10 #112🛠️ Updated/Changed:
Websocket.receive()andWebsocket._handle_frame()to work with fragmented messagesWebsocket._bufferwas refactored to be initialized once and reused, instead of inside every._read_frame()callBefore merge, I would appreciate anyones input on these topics:
monotonic_nsbecause it should not lose precision after multiple hours, is it correct to assume that any microcontroller that would be able to support Websockets will also be able to support long ints required for ns precision?.receive()until a message is completed, it will append received payload and hold it over maybe even multiple.receive()calls until it is complete, and only then will return it, I believe it is a more asynchronous approach than blocking, but I would like to gather feedback on that.Any testing and feedback would be appreciated.