Fix deprecated type and erroneous function calls #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just bought a eink display from AdaFruit, as well as STM32 feather board, and wanted to give a try to this library.
However, out of the box, I found two errors and a warning when using my usual toolchain (Platformio + STM32duino).
boolean
Arduino type. As stated here, this type is deprecated and totally equivalent to the standardbool
type. While this is not a blocking issue, I always intend as fixing every warning when coding, so that I can see in a glimpse in my terminal that everything went well.min()
function with different data type for the arguments. As one can see here, both arguments must be of the same type, and these calls mixeduint32_t
type with the result of thesizeof()
operator, which returns asize_t
, as stated here. This is a blocking error with my toolchain, and could be resolved easily by casting the result of thesizeof()
operator used as one of the argument to match the other.I can't see any use case in which these changes would cause any issue, as one commit is the resolution of a deprecated type to the matching standard type, and the other tend to follow the C++ correct syntax.
Big love to AdaFruit and its wonderful products!