Skip to content

Use int16_t for pins instead of int8_t #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use int16_t for pins instead of int8_t #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
240a43d
Use int16_t for pins instead of int8_t
asukiaaa Sep 6, 2022
9f6dd33
Add change line to adjust line length
asukiaaa Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Adafruit_ILI9341.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@
@param miso SPI MISO pin # (optional, pass -1 if unused)
*/
/**************************************************************************/
Adafruit_ILI9341::Adafruit_ILI9341(int8_t cs, int8_t dc, int8_t mosi,
int8_t sclk, int8_t rst, int8_t miso)
Adafruit_ILI9341::Adafruit_ILI9341(int16_t cs, int16_t dc, int16_t mosi,
int16_t sclk, int16_t rst, int16_t miso)
: Adafruit_SPITFT(ILI9341_TFTWIDTH, ILI9341_TFTHEIGHT, cs, dc, mosi, sclk,
rst, miso) {}

Expand All @@ -106,7 +106,7 @@ Adafruit_ILI9341::Adafruit_ILI9341(int8_t cs, int8_t dc, int8_t mosi,
@param rst Reset pin # (optional, pass -1 if unused).
*/
/**************************************************************************/
Adafruit_ILI9341::Adafruit_ILI9341(int8_t cs, int8_t dc, int8_t rst)
Adafruit_ILI9341::Adafruit_ILI9341(int16_t cs, int16_t dc, int16_t rst)
: Adafruit_SPITFT(ILI9341_TFTWIDTH, ILI9341_TFTHEIGHT, cs, dc, rst) {}

#if !defined(ESP8266)
Expand All @@ -121,8 +121,8 @@ Adafruit_ILI9341::Adafruit_ILI9341(int8_t cs, int8_t dc, int8_t rst)
@param rst Reset pin # (optional, pass -1 if unused).
*/
/**************************************************************************/
Adafruit_ILI9341::Adafruit_ILI9341(SPIClass *spiClass, int8_t dc, int8_t cs,
int8_t rst)
Adafruit_ILI9341::Adafruit_ILI9341(SPIClass *spiClass, int16_t dc, int16_t cs,
int16_t rst)
: Adafruit_SPITFT(ILI9341_TFTWIDTH, ILI9341_TFTHEIGHT, spiClass, cs, dc,
rst) {}
#endif // end !ESP8266
Expand All @@ -142,8 +142,9 @@ Adafruit_ILI9341::Adafruit_ILI9341(SPIClass *spiClass, int8_t dc, int8_t cs,
@param rd Read strobe pin # (optional, pass -1 if unused).
*/
/**************************************************************************/
Adafruit_ILI9341::Adafruit_ILI9341(tftBusWidth busWidth, int8_t d0, int8_t wr,
int8_t dc, int8_t cs, int8_t rst, int8_t rd)
Adafruit_ILI9341::Adafruit_ILI9341(tftBusWidth busWidth, int16_t d0, int16_t wr,
int16_t dc, int16_t cs, int16_t rst,
int16_t rd)
: Adafruit_SPITFT(ILI9341_TFTWIDTH, ILI9341_TFTHEIGHT, busWidth, d0, wr, dc,
cs, rst, rd) {}

Expand Down
14 changes: 7 additions & 7 deletions Adafruit_ILI9341.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ work with ILI9340)

class Adafruit_ILI9341 : public Adafruit_SPITFT {
public:
Adafruit_ILI9341(int8_t _CS, int8_t _DC, int8_t _MOSI, int8_t _SCLK,
int8_t _RST = -1, int8_t _MISO = -1);
Adafruit_ILI9341(int8_t _CS, int8_t _DC, int8_t _RST = -1);
Adafruit_ILI9341(int16_t _CS, int16_t _DC, int16_t _MOSI, int16_t _SCLK,
int16_t _RST = -1, int16_t _MISO = -1);
Adafruit_ILI9341(int16_t _CS, int16_t _DC, int16_t _RST = -1);
#if !defined(ESP8266)
Adafruit_ILI9341(SPIClass *spiClass, int8_t dc, int8_t cs = -1,
int8_t rst = -1);
Adafruit_ILI9341(SPIClass *spiClass, int16_t dc, int16_t cs = -1,
int16_t rst = -1);
#endif // end !ESP8266
Adafruit_ILI9341(tftBusWidth busWidth, int8_t d0, int8_t wr, int8_t dc,
int8_t cs = -1, int8_t rst = -1, int8_t rd = -1);
Adafruit_ILI9341(tftBusWidth busWidth, int16_t d0, int16_t wr, int16_t dc,
int16_t cs = -1, int16_t rst = -1, int16_t rd = -1);

void begin(uint32_t freq = 0);
void setRotation(uint8_t r);
Expand Down