quick fix broken imports/calls of pcf8523 #2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks. These LGTM in terms of syntax. As an additional reference, these updates are consistent with what was done in this similar PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several example files incorrectly
import adafruit_pcf8523and dortc = adafruit_pcf8523.PCF8523(I2C)when they shouldfrom adafruit_pcf8523.pcf8523 import PCF8523andrtc = PCF8523(I2C). This PR corrects these imports and makes no other changes. I don't own the various bits of hardware necessary to test these examples, but my changes here should have no other impact.