Open
Conversation
Noticed that midnight was not handled properly for cases like "Five to Midnight" or "Twenty after Midnight". Was seeing noon instead of midnight.
Member
|
@elmwoodelec Thank you for submitting a Pull Request. Your code is currently not passing the linter due to an Once you fix that up, re-commit and we'll take a look! |
Added a special case so clock shows "xxx TO MIDNIGHT" or "xxx PAST MIDNIGHT" instead of "xxx TO NOON" or "xxx PAST MIDNIGHT". Midnight was only working properly if the display time was exactly midnight.
elmwoodelec
commented
Jul 27, 2019
Author
elmwoodelec
left a comment
elmwoodelec
left a comment
There was a problem hiding this comment.
Noticed that midnight was not handled properly for cases like "Five to Midnight" or "Twenty after Midnight". Was seeing noon instead of midnight.
Member
|
@elmwoodelec This branch is out-of-date with master, you'll need to merge the latest changes from @TheKitty Could you take a look at this PR and review? |
Collaborator
|
Let me know when ready and I'll check
…On Thu, Aug 8, 2019 at 9:22 AM Brent Rubell ***@***.***> wrote:
@elmwoodelec <https://github.com/elmwoodelec> This branch is out-of-date
with master, you'll need to merge the latest changes from master into it.
@TheKitty <https://github.com/TheKitty> Could you take a look at this PR
and review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#775?email_source=notifications&email_token=AAOSY4GAEG6MYIGMX5Z6B2LQDQMZNA5CNFSM4IF4TAB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33S3VA#issuecomment-519515604>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOSY4FCZZET26G5HTCOI6LQDQMZNANCNFSM4IF4TABQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that midnight was not handled properly for cases like "Five to Midnight" or "Twenty after Midnight". Was seeing noon instead of midnight.