Skip to content

Conversation

MstrVLT
Copy link

@MstrVLT MstrVLT commented Feb 4, 2019

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

@MstrVLT
Copy link
Author

MstrVLT commented Feb 4, 2019

my lolin d1 (wemos, china esp8266) oled shield need fix library
and thx @mcauser

@dok-net
Copy link

dok-net commented Mar 27, 2019

Could please withdraw your PR, and support #136? It is an even more comprehensive merge of mcauser's changes.

@dok-net
Copy link

dok-net commented Jul 18, 2019

@MstrVLT @ladyada This PR is dead in the water?

@MstrVLT
Copy link
Author

MstrVLT commented Jul 19, 2019

@dok-net I have no idea why this PR is not reviewing (

@dok-net
Copy link

dok-net commented Jul 19, 2019

@MstrVLT Could you please try #136 instead and close this? It solves a few more of the specifics of the 64x48 boards.

@MstrVLT
Copy link
Author

MstrVLT commented Sep 21, 2019

@MstrVLT Could you please try #136 instead and close this? It solves a few more of the specifics of the 64x48 boards.

yep is working now with for platformio:
lib_deps = Adafruit_SSD1306=https://github.com/dok-net/Adafruit_SSD1306/archive/master.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants