Skip to content

seesaw_neopixel::clear(): Fix write buffer size #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

seesaw_neopixel::clear(): Fix write buffer size #43

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
94c19ce
seesaw_neopixel::clear(): Fix write buffer size
unvirtual May 24, 2021
028e9ba
Add simple BitMask class
unvirtual Jun 3, 2021
53d87bc
seesaw_neopixel: Add setPixelRangeColors()
unvirtual Jun 3, 2021
9712e65
seesaw_neopixel: implement clear(uint32_t color) in terms of setPixel…
unvirtual Jun 3, 2021
d04ac00
Adafruit_Neotrellis: add clear(uint32_t color)
unvirtual Jun 3, 2021
3db779a
Adafruit_MultiTrellis: add setPixelColorsInRect()
unvirtual Jun 3, 2021
b8abe5c
Adafruit_MultiTrellis: add setRowColors() and setColumnColors()
unvirtual Jun 3, 2021
dc8718b
seesaw_neopixel: clean up and fix isBulkWriteFastest() for RGBW LEDs.
unvirtual Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions seesaw_neopixel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,13 +284,15 @@ void seesaw_NeoPixel::clear() {
// Clear local pixel buffer
memset(pixels, 0, numBytes);

// Now clear the pixels on the seesaw
uint8_t writeBuf[32];
memset(writeBuf, 0, 32);
// Now clear the pixels on the seesaw.
// Max write buffer size is I2C buffer limit (32 bytes) minus sizes
// for seesaw regHigh (1 byte) and regLow (1 byte).
uint8_t writeBuf[30];
memset(writeBuf, 0, 30);
for (uint8_t offset = 0; offset < numBytes; offset += 32 - 4) {
writeBuf[0] = (offset >> 8);
writeBuf[1] = offset;
this->write(SEESAW_NEOPIXEL_BASE, SEESAW_NEOPIXEL_BUF, writeBuf, 32);
this->write(SEESAW_NEOPIXEL_BASE, SEESAW_NEOPIXEL_BUF, writeBuf, 30);
}
}

Expand Down