Philhower's platform_def defines PICO_RP2040 and PICO_RP2350 - #30
Open
markwal wants to merge 1 commit into
Open
Conversation
The Arduino instructions on the learn page for the Adafruit Macro Pad say to install the Earle Philhower board support for the RP2040. The i2c_scan example given in that tutorial won't compile with an error about NOPT1H_CYCLE is undefined. This is because ARDUINO_RASPBERRY_PI_PICO is not defined. However, PICO_RP2040 is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arduino instructions on the learn page for the Adafruit Macro Pad say to install the Earle Philhower board support for the RP2040. The i2c_scan example given in that tutorial won't compile with an error about NOPT1H_CYCLE is undefined. This is because ARDUINO_RASPBERRY_PI_PICO is not defined. However, PICO_RP2040 is.
Scope: Changes Adafruit_TestBed_Brains.cpp. Allows PICO_RP2040 and PICO_RP2350 to determine the CYCLE times as synonyms for ARDUINO_RASPBERRY_PI_PICO and ARDUINO_RASPBERRY_PI_PICO2. The way the ifdef is structured, either PICO_RP2040 or ARDUINO_RASPBERRY_PI_PICO being defined will take precedence over the 2350 macros being defined.
I tested the learn example given above.