Call out Arduino namespace in Adafruit_USBH_CDC#489
Closed
earlephilhower wants to merge 1 commit intoadafruit:masterfrom
Closed
Call out Arduino namespace in Adafruit_USBH_CDC#489earlephilhower wants to merge 1 commit intoadafruit:masterfrom
earlephilhower wants to merge 1 commit intoadafruit:masterfrom
Conversation
Contributor
Author
|
Ooops...looks like some of the NRF and CPB Arduino cores are older than the 6-year mark. Will update... |
Contributor
Author
|
Let me close this as there seems to be some really old API revs out there. Will work on the API branch itself. Sorry for the churn! |
Member
|
yeah, there is other core using TinyUSB which isn't upgraded to latest API. If it is essential/required, I will try to revise other cores. |
Contributor
Author
|
No, thanks anyway. I just added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HardwareSerialArduino base class does not always get exposed with ausing namespace arduinostatement, and with the latest Arduino API 1.5.1 this causes Arduino-Pico to fail building the CDC serial port examples.earlephilhower/arduino-pico#2797
This change is compatible with all other Arduino API levels for the last 6 years since the encapsulation was done then:
arduino/ArduinoCore-API@fc0c12d